Skip to content

Global freelist #29089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
methane wants to merge 7 commits into from
Closed

Global freelist #29089

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8f0e37
Minimum implementation of global freelist.
methane Oct 20, 2021
4cb792f
frame uses global freelist
methane Oct 20, 2021
47e114c
tuple uses global freelist
methane Oct 20, 2021
d239b20
unicode allocate memory from freelist.
methane Oct 20, 2021
4d6f7c3
list uses freelist
methane Oct 20, 2021
38175d0
list uses global freelist
methane Oct 20, 2021
b3def6f
dict object uses global freelist.
methane Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tuple uses global freelist
  • Loading branch information
@methane
methane committed Oct 20, 2021
commit 47e114c9e36023db6f2975ef28b1532dfd30124c
55 changes: 7 additions & 48 deletions Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,35 +66,12 @@ tuple_alloc(Py_ssize_t size)
return NULL;
}

#if PyTuple_MAXSAVESIZE > 0
struct _Py_tuple_state *state = get_tuple_state();
#ifdef Py_DEBUG
// tuple_alloc() must not be called after _PyTuple_Fini()
assert(state->numfree[0] != -1);
#endif
if (size < PyTuple_MAXSAVESIZE && (op = state->free_list[size]) != NULL) {
assert(size != 0);
state->free_list[size] = (PyTupleObject *) op->ob_item[0];
state->numfree[size]--;
/* Inlined _PyObject_InitVar() without _PyType_HasFeature() test */
#ifdef Py_TRACE_REFS
Py_SET_SIZE(op, size);
Py_SET_TYPE(op, &PyTuple_Type);
#endif
_Py_NewReference((PyObject *)op);
}
else
#endif
{
/* Check for overflow */
if ((size_t)size > ((size_t)PY_SSIZE_T_MAX - (sizeof(PyTupleObject) -
sizeof(PyObject *))) / sizeof(PyObject *)) {
return (PyTupleObject *)PyErr_NoMemory();
}
op = PyObject_GC_NewVar(PyTupleObject, &PyTuple_Type, size);
if (op == NULL)
return NULL;
/* Check for overflow */
if ((size_t)size > ((size_t)PY_SSIZE_T_MAX - (sizeof(PyTupleObject) -
sizeof(PyObject *))) / sizeof(PyObject *)) {
return (PyTupleObject *)PyErr_NoMemory();
}
op = PyObject_GC_NewVar(PyTupleObject, &PyTuple_Type, size);
return op;
}

Expand Down Expand Up @@ -271,22 +248,7 @@ tupledealloc(PyTupleObject *op)
while (--i >= 0) {
Py_XDECREF(op->ob_item[i]);
}
#if PyTuple_MAXSAVESIZE > 0
struct _Py_tuple_state *state = get_tuple_state();
#ifdef Py_DEBUG
// tupledealloc() must not be called after _PyTuple_Fini()
assert(state->numfree[0] != -1);
#endif
if (len < PyTuple_MAXSAVESIZE
&& state->numfree[len] < PyTuple_MAXFREELIST
&& Py_IS_TYPE(op, &PyTuple_Type))
{
op->ob_item[0] = (PyObject *) state->free_list[len];
state->numfree[len]++;
state->free_list[len] = op;
goto done; /* return */
}
#endif
_PyObject_GC_RecycleVar(op, &PyTuple_Type, len);
}
#if defined(Py_DEBUG) && PyTuple_MAXSAVESIZE > 0
else {
Expand All @@ -297,13 +259,10 @@ tupledealloc(PyTupleObject *op)
if (op == state->free_list[0] && state->numfree[0] != 0) {
_Py_FatalRefcountError("deallocating the empty tuple singleton");
}
Py_TYPE(op)->tp_free((PyObject *)op);
}
#endif
Py_TYPE(op)->tp_free((PyObject *)op);

#if PyTuple_MAXSAVESIZE > 0
done:
#endif
Py_TRASHCAN_END
}

Expand Down