Skip to content

bpo-30570: Use Py_EnterRecursiveCall() in issubclass() #29048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 3 commits into from
Oct 22, 2021
Merged

bpo-30570: Use Py_EnterRecursiveCall() in issubclass() #29048

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c3276e
Use Py_EnterRecursiveCall() in issubclass()
sweeneyde Oct 19, 2021
21c5b0f
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 19, 2021
f0cf002
Add an additional test case.
gpshead Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add an additional test case.
  • Loading branch information
@gpshead
gpshead committed Oct 22, 2021
commit f0cf002ee71fade314618242838c4fb4eb625330
13 changes: 11 additions & 2 deletions Lib/test/test_isinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,25 @@ def __bases__(self):
self.assertRaises(RecursionError, issubclass, int, X())
self.assertRaises(RecursionError, isinstance, 1, X())

def test_infinite_recursion_via_bases_tuple(self):
"""Regression test for bpo-30570."""
class Failure(object):
def __getattr__(self, attr):
return (self, None)

with self.assertRaises(RecursionError):
issubclass(Failure(), int)

def test_infinite_cycle_in_bases(self):
# bpo-30570
"""Regression test for bpo-30570."""
class X:
@property
def __bases__(self):
return (self, self, self)
self.assertRaises(RecursionError, issubclass, X(), int)

def test_infinitely_many_bases(self):
# bpo-30570
"""Regression test for bpo-30570."""
class X:
def __getattr__(self, attr):
self.assertEqual(attr, "__bases__")
Expand Down