Skip to content

gh-75223: Reject undotted extensions in mimetypes.add_type #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
OddBloke wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

gh-75223: Reject undotted extensions in mimetypes.add_type #2895

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2e6a0e5
Add a test for mimetypes.add_type
OddBloke Jul 26, 2017
1485be9
bpo-31040: Reject undotted extensions in mimetypes.add_type
OddBloke Jul 26, 2017
f0c1bf7
Address the review
arhadthedev Apr 15, 2023
0d9bec2
Merge branch 'main' into fix-for-31040
arhadthedev Apr 15, 2023
2f23267
Merge branch 'main' into fix-for-31040
hugovk Nov 6, 2024
ef5cf14
Assert output first, expected result second; link to method in news
hugovk Nov 16, 2024
bac8d5d
Assert adding MIME type with empty extension emits no warning
hugovk Nov 16, 2024
e177398
Assert exception message when adding MIME type with undotted extension
hugovk Nov 16, 2024
094f69b
Remove unused import
hugovk Nov 16, 2024
cbc5421
Fix Sphinx reference; replace bpo with gh-issue
hugovk Nov 16, 2024
41d4e89
Replace with more useful test case
hugovk Nov 16, 2024
50179cf
Improve wording: avoid triple negative
hugovk Nov 16, 2024
352811b
Fix news filename
hugovk Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address the review
  • Loading branch information
@arhadthedev
arhadthedev authored Apr 15, 2023
commit f0c1bf701e559aeee1bcd34a17087b609bc7facd
6 changes: 2 additions & 4 deletions Lib/mimetypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,8 @@ def add_type(self, type, ext, strict=True):
valid, so a ValueError will be raised if they are
specified.
"""
if not ext:
warnings.warn('Empty extension specified')
elif not ext.startswith('.'):
raise ValueError("Extensions should start with a '.'")
if ext and not ext.startswith('.'):
raise ValueError("Extensions should start with a '.' or be empty")
self.types_map[strict][ext] = type
exts = self.types_map_inv[strict].setdefault(type, [])
if ext not in exts:
Expand Down