Skip to content

bpo-45256: Avoid C calls for more Python to Python calls. #28937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 6 commits into from
Oct 18, 2021
Merged

bpo-45256: Avoid C calls for more Python to Python calls. #28937

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78b869e
Avoid making C calls for most calls to Python functions.
markshannon Oct 11, 2021
73041b5
Refactor a bit to help parsing of instructions.
markshannon Oct 13, 2021
5cc5442
Update gdb test to account for fewer C calls.
markshannon Oct 13, 2021
7c0f498
Change initialize_locals(steal=true) and _PyTuple_FromArraySteal to c…
markshannon Oct 14, 2021
03e7ad9
Fix compiler warnings on Windows.
markshannon Oct 14, 2021
82f5093
Rename labels and variable for clarity.
markshannon Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compiler warnings on Windows.
  • Loading branch information
@markshannon
markshannon committed Oct 14, 2021
commit 03e7ad9fa0fd5235bfea7785817a4685663ee5bd
4 changes: 2 additions & 2 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4584,14 +4584,14 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr
kwnames = POP();
int is_method = (PEEK(oparg + 2) != NULL);
oparg += is_method;
nargs = oparg - PyTuple_GET_SIZE(kwnames);
nargs = oparg - (int)PyTuple_GET_SIZE(kwnames);
Comment thread
markshannon marked this conversation as resolved.
stackadj = 2-is_method;
goto call_function;
}

TARGET(CALL_FUNCTION_KW) {
kwnames = POP();
nargs = oparg - PyTuple_GET_SIZE(kwnames);
nargs = oparg - (int)PyTuple_GET_SIZE(kwnames);
stackadj = 1;
goto call_function;
}
Expand Down