Skip to content

[3.10] Fix dataclassses spelling (GH-28837) #28841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 1 commit into from
Oct 9, 2021
Merged

[3.10] Fix dataclassses spelling (GH-28837) #28841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix dataclassses spelling (GH-28837) 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <33426811+jly36963@users.noreply.github.com>
  • Loading branch information
@jly36963 @miss-islington
jly36963 authored and miss-islington committed Oct 9, 2021
commit ab5b1bc863509690998160051feba1dc494d720b
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.10.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ Added ``slots`` parameter in :func:`dataclasses.dataclass` decorator.
Keyword-only fields
~~~~~~~~~~~~~~~~~~~

dataclassses now supports fields that are keyword-only in the
dataclasses now supports fields that are keyword-only in the
generated __init__ method. There are a number of ways of specifying
keyword-only fields.

Expand Down
2 changes: 1 addition & 1 deletion Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ def exec_body_callback(ns):
ns['__annotations__'] = annotations

# We use `types.new_class()` instead of simply `type()` to allow dynamic creation
# of generic dataclassses.
# of generic dataclasses.
cls = types.new_class(cls_name, bases, {}, exec_body_callback)

# Apply the normal decorator.
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,7 @@ class Parent(Generic[T]):
# Check MRO resolution.
self.assertEqual(Child.__mro__, (Child, Parent, Generic, object))

def test_dataclassses_pickleable(self):
def test_dataclasses_pickleable(self):
global P, Q, R
@dataclass
class P:
Expand Down