[3.9] bpo-44594: fix (Async)ExitStack handling of __context__ (gh-27089)#28731
Merged
Conversation
…gh-27089) * bpo-44594: fix (Async)ExitStack handling of __context__ Make enter_context(foo()) / enter_async_context(foo()) equivalent to `[async] with foo()` regarding __context__ when an exception is raised. Previously exceptions would be caught and re-raised with the wrong context when explicitly overriding __context__ with None.. (cherry picked from commit e6d1aa1) Co-authored-by: John Belmonte <john@neggie.net>
njsmith
approved these changes
Oct 5, 2021
Contributor
|
@belm0: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make enter_context(foo()) / enter_async_context(foo()) equivalent to
[async] with foo()regarding context when an exception is raised.Previously exceptions would be caught and re-raised with the wrong
context when explicitly overriding context with None..
(cherry picked from commit e6d1aa1)
Co-authored-by: John Belmonte john@neggie.net
https://bugs.python.org/issue44594
Automerge-Triggered-By: GH:njsmith