Skip to content

bpo-31009: Fix support.fd_count() on Windows#2862

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:fd_count_win
Jul 25, 2017
Merged

bpo-31009: Fix support.fd_count() on Windows#2862
vstinner merged 2 commits into
python:masterfrom
vstinner:fd_count_win

Conversation

@vstinner

@vstinner vstinner commented Jul 25, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

On Windows, test.support.fd_count() now calls
msvcrt.CrtSetReportMode() to not kill the process nor log any error
on stderr on os.dup(fd) if the file descriptor is invalid.

https://bugs.python.org/issue31009

@vstinner vstinner requested a review from pitrou July 25, 2017 12:10
@vstinner

vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member Author

I tested manually: test_child_fd_inflation() of test_multiprocessing_spawn doesn't hang anymore on a debug build on Windows. Moreover, test_regrtest still pass.

" continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request" I don't understand this error :-( My commit is just on top on master. I updated my local Git clone, there is no new commt in master.

@vstinner

vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member Author

I ran manually the test suite on Windows: all tests pass. To be honest, test_distutils fails, but it's unrelated to this change and I don't know how to fix my Windows support to get a working C compiler...

@vstinner

vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member Author

"AppVeyor was unable to build non-mergeable pull request" : "To rebuild that PR you can close and then re-open it."
http://help.appveyor.com/discussions/problems/4830-stuck-on-appveyor-was-unable-to-build-non-mergeable

@vstinner vstinner closed this Jul 25, 2017
@vstinner vstinner reopened this Jul 25, 2017
@vstinner
bpo-31009: Fix support.fd_count() on Windows
905898a 
On Windows, test.support.fd_count() now calls
msvcrt.CrtSetReportMode() to not kill the process nor log any error
on stderr on os.dup(fd) if the file descriptor is invalid.
@vstinner

vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member Author

Crap, there was a whitespace issue... "Fixing Python file whitespace ... 1 file: Lib/test/support/init.py". It's now fixed.

@vstinner

vstinner commented Jul 25, 2017

Copy link
Copy Markdown
Member Author

Travis CI failed on downloading Python 3.6 on the docs job :-(

Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/3.6-python.tar.bz2
$ sudo tar xjf python-3.6.tar.bz2 --directory /
bzip2: (stdin) is not a bzip2 file.

@vstinner vstinner merged commit 302bbbe into python:master Jul 25, 2017
@vstinner vstinner deleted the fd_count_win branch July 25, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou Awaiting requested review from pitrou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni