Skip to content

bpo-45243: Add support for setting/getting sqlite3 connection limits #28463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 16 commits into from
Nov 1, 2021
+228 −1
Merged

bpo-45243: Add support for setting/getting sqlite3 connection limits #28463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
39d69ce
bpo-45243: Add support for setting/getting sqlite3 connection limits
Sep 19, 2021
6fd1c74
Add docs
Sep 19, 2021
3514179
Add NEWS
Sep 19, 2021
c5abeb0
Add What's New
Sep 19, 2021
76d2c2b
SQLITE_LIMIT_WORKER_THREADS appeared in SQLite 3.8.7
Sep 19, 2021
2373a95
Merge branch 'main' into sqlite-limits
Oct 6, 2021
a51f286
Remove debug print
Oct 7, 2021
e093a99
Raise ProgrammingError if limit is out of bounds
Oct 7, 2021
fced0ce
SQLITE_LIMIT_WORKER_THREADS is defined in SQLite 3.8.7, not 3.8.3
Oct 7, 2021
4f7c2c0
SQLite version is found in sqlite3.sqlite_version_info, not sqlite3.v…
Oct 7, 2021
5e2ae97
Improve argument spec
Oct 8, 2021
1c36d95
Drop 'Non-standard' from docstring
Oct 8, 2021
eb6c233
Expand test suite
Oct 21, 2021
c1d828f
Merge branch 'main' into sqlite-limits
Oct 21, 2021
28b514a
Merge branch 'main' into sqlite-limits
Oct 31, 2021
872f1ef
Merge branch 'main' into sqlite-limits
Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SQLITE_LIMIT_WORKER_THREADS appeared in SQLite 3.8.7 
https://sqlite.org/changes.html
  • Loading branch information
Erlend E. Aasland committed Sep 19, 2021
commit 76d2c2b0cf688d954bdaebf8f1f397b63f7b8bb7
3 changes: 2 additions & 1 deletion Lib/sqlite3/test/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,13 @@ def test_module_constants(self):
"SQLITE_LIMIT_LIKE_PATTERN_LENGTH",
"SQLITE_LIMIT_VARIABLE_NUMBER",
"SQLITE_LIMIT_TRIGGER_DEPTH",
"SQLITE_LIMIT_WORKER_THREADS",
]
if sqlite.version_info >= (3, 7, 17):
consts += ["SQLITE_NOTICE", "SQLITE_WARNING"]
if sqlite.version_info >= (3, 8, 3):
consts.append("SQLITE_RECURSIVE")
if sqlite.version_info >= (3, 8, 7):
consts.append("SQLITE_LIMIT_WORKER_THREADS")
consts += ["PARSE_DECLTYPES", "PARSE_COLNAMES"]
for const in consts:
with self.subTest(const=const):
Expand Down
2 changes: 2 additions & 0 deletions Modules/_sqlite/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,9 @@ static int add_integer_constants(PyObject *module) {
ret += PyModule_AddIntMacro(module, SQLITE_LIMIT_LIKE_PATTERN_LENGTH);
ret += PyModule_AddIntMacro(module, SQLITE_LIMIT_VARIABLE_NUMBER);
ret += PyModule_AddIntMacro(module, SQLITE_LIMIT_TRIGGER_DEPTH);
#if SQLITE_VERSION_NUMBER >= 3008003
ret += PyModule_AddIntMacro(module, SQLITE_LIMIT_WORKER_THREADS);
#endif
return ret;
}

Expand Down