Skip to content

[doc] Add a missing apostrophe in a code example in venv.rst#28391

Merged
ambv merged 2 commits into
python:mainfrom
ArkaprabhaChakraborty:patch-2
Sep 17, 2021
Merged

[doc] Add a missing apostrophe in a code example in venv.rst#28391
ambv merged 2 commits into
python:mainfrom
ArkaprabhaChakraborty:patch-2

Conversation

@ArkaprabhaChakraborty
Copy link
Copy Markdown
Contributor

@ArkaprabhaChakraborty ArkaprabhaChakraborty commented Sep 16, 2021

documentation update

@ArkaprabhaChakraborty
added missing ' in main
92f4b6d 
documentation update
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Sep 16, 2021
ambv
ambv reviewed Sep 17, 2021
View reviewed changes
Comment thread Doc/library/venv.rst Outdated
Comment on lines 429 to 430
help='A directory in which to create the'
'virtual environment.')
Copy link
Copy Markdown
Contributor

@ambv ambv Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a space before the apostrophe.

Copy link
Copy Markdown
Contributor Author

@ArkaprabhaChakraborty ArkaprabhaChakraborty Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. But the sample code was giving an error so I just sent a change to resolve it. Ill add the space

@ambv ambv changed the title added missing ' in main [doc] Add a missing apostrophe in a code example in venv.rst Sep 17, 2021
@ambv ambv merged commit d22a700 into python:main Sep 17, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 17, 2021

Thanks @ArkaprabhaChakraborty for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 17, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 17, 2021

GH-28425 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 17, 2021

GH-28426 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (pythonG…
e0fd060 
…H-28391)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (pythonG…
64a253e 
…H-28391)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
ambv pushed a commit that referenced this pull request Sep 17, 2021
@miss-islington @ArkaprabhaChakraborty
[doc] Add a missing apostrophe in a code example in venv.rst (GH-28391)…
c4be7ca 
… (GH-28425)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
ambv pushed a commit that referenced this pull request Sep 17, 2021
@miss-islington @ArkaprabhaChakraborty
[doc] Add a missing apostrophe in a code example in venv.rst (GH-28391)…
129e477 
… (GH-28426)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@ArkaprabhaChakraborty @niyas-sait
[doc] Add a missing apostrophe in a code example in venv.rst (pythonG…
d2daac5 
…H-28391)
pablogsal pushed a commit that referenced this pull request Sep 29, 2021
@miss-islington @ArkaprabhaChakraborty @pablogsal
[doc] Add a missing apostrophe in a code example in venv.rst (GH-28391)…
0a94253 
… (GH-28425)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ArkaprabhaChakraborty @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni