bpo-44964: Add a note explaining the new semantics of f_last_i in frame objects#28200
Merged
Conversation
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2021
…me objects (pythonGH-28200) (cherry picked from commit fa2c0b8) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-28202 is a backport of this pull request to the 3.10 branch. |
markshannon
reviewed
Sep 7, 2021
| global variables; :attr:`f_builtins` is used for built-in (intrinsic) names; | ||
| :attr:`f_lasti` gives the precise instruction (this is an index into the | ||
| bytecode string of the code object). | ||
| :attr:`f_lasti` gives the precise instruction (it represents a wordcode index, which |
Member
There was a problem hiding this comment.
This is incorrect. f_lasti is the index in the bytecode. No need to multiply by two.
markshannon
reviewed
Sep 7, 2021
| source_buf = PyBytes_AsString(source_bytes_object); | ||
| code = Py_CompileString(source_buf, filename, Py_file_input); | ||
|
|
||
| * For ``FrameObject`` objects, the ``f_lasti`` member now represents a wordcode |
Member
There was a problem hiding this comment.
Can you add a note to use PyFrame_GetLineNumber() instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44964