Skip to content

bpo-45026: More compact range iterator (alt) #28176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 15 commits into from
Closed

bpo-45026: More compact range iterator (alt) #28176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2fa0b0d
bpo-45026: More compact range iterator
serhiy-storchaka Aug 27, 2021
1cd0138
Fix sizeof test.
serhiy-storchaka Aug 27, 2021
214f204
Merge branch 'main' into range-iter
serhiy-storchaka Aug 29, 2021
3133f66
Add explicit tests for __setstate__.
serhiy-storchaka Aug 29, 2021
7a42474
Add a NEWS entry.
serhiy-storchaka Aug 29, 2021
175b0d3
Merge branch 'main' into range-iter
serhiy-storchaka Sep 5, 2021
177da8c
Keep stop instead of len.
serhiy-storchaka Sep 5, 2021
155cb3c
Merge branch 'main' into range-iter2
serhiy-storchaka Sep 10, 2021
dced0e6
Fix refleaks.
serhiy-storchaka Sep 10, 2021
3219849
Merge branch 'main' into range-iter2
serhiy-storchaka Sep 15, 2021
cffa90a
Merge branch 'main' into range-iter2
serhiy-storchaka Sep 24, 2021
dbdb0cc
Merge branch 'main' into range-iter2
serhiy-storchaka Mar 28, 2022
109445f
Merge branch 'main' into range-iter2
serhiy-storchaka Nov 27, 2022
189ca23
Unify code with range-iter.
serhiy-storchaka Nov 27, 2022
d315911
Microoptimize small range iteration.
serhiy-storchaka Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Microoptimize small range iteration.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Nov 29, 2022
commit d3159110639c8b0468b84d9b58955ce751681310
6 changes: 3 additions & 3 deletions Objects/rangeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,9 +784,9 @@ get_len_of_range(long lo, long hi, long step)
static PyObject *
rangeiter_next(_PyRangeIterObject *r)
{
if (r->step > 0 ? r->start < r->stop : r->start > r->stop) {
long result = r->start;
r->start = result + r->step;
long result = r->start, step = r->step;
if (step > 0 ? result < r->stop : result > r->stop) {
r->start = result + step;
return PyLong_FromLong(result);
}
return NULL;
Expand Down
6 changes: 3 additions & 3 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,14 +2620,14 @@ dummy_func(
STAT_INC(FOR_ITER, hit);
_Py_CODEUNIT next = next_instr[INLINE_CACHE_ENTRIES_FOR_ITER];
assert(_PyOpcode_Deopt[_Py_OPCODE(next)] == STORE_FAST);
if (r->step > 0 ? r->start >= r->stop : r->start <= r->stop) {
long value = r->start, step = r->step;
if (step > 0 ? value >= r->stop : value <= r->stop) {
STACK_SHRINK(1);
Py_DECREF(r);
JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1);
}
else {
long value = r->start;
r->start = value + r->step;
r->start = value + step;
if (_PyLong_AssignValue(&GETLOCAL(_Py_OPARG(next)), value) < 0) {
goto error;
}
Expand Down
6 changes: 3 additions & 3 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.