Skip to content

bpo-45089: raise exceptions on error in sqlite3 trace callback #28133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland wants to merge 3 commits into from
Closed

bpo-45089: raise exceptions on error in sqlite3 trace callback #28133

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
059f0cf
bpo-45089: sqlite3 trace callbacks no longer clears exceptions
Sep 2, 2021
0af5288
NEWS entry
Sep 2, 2021
33b4b69
Merge branch 'main' into sqlite-trace-exception
Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into sqlite-trace-exception
  • Loading branch information
Erlend E. Aasland committed Sep 7, 2021
commit 33b4b6974402df63409ec182f58b496401976a62
2 changes: 1 addition & 1 deletion Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ trace_callback(void *ctx, const char *statement_string)
goto exit;
}

PyObject *ret = PyObject_CallOneArg((PyObject*)user_arg, py_statement);
PyObject *ret = PyObject_CallOneArg((PyObject *)ctx, py_statement);
Py_DECREF(py_statement);
if (ret == NULL) {
pysqlite_state *state = pysqlite_get_state(NULL);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.