Skip to content

gh-89189: More compact range iterator #27986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 12 commits into from
Nov 30, 2022
Merged

gh-89189: More compact range iterator #27986

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2fa0b0d
bpo-45026: More compact range iterator
serhiy-storchaka Aug 27, 2021
1cd0138
Fix sizeof test.
serhiy-storchaka Aug 27, 2021
214f204
Merge branch 'main' into range-iter
serhiy-storchaka Aug 29, 2021
3133f66
Add explicit tests for __setstate__.
serhiy-storchaka Aug 29, 2021
7a42474
Add a NEWS entry.
serhiy-storchaka Aug 29, 2021
175b0d3
Merge branch 'main' into range-iter
serhiy-storchaka Sep 5, 2021
22f76b8
Merge branch 'main' into range-iter
serhiy-storchaka Sep 15, 2021
20e3149
Merge branch 'main' into range-iter
serhiy-storchaka Sep 24, 2021
abf2971
Merge branch 'main' into range-iter
serhiy-storchaka Mar 28, 2022
0ca67c2
Merge branch 'main' into range-iter
serhiy-storchaka Nov 27, 2022
10822c0
Microoptimize small range iteration.
serhiy-storchaka Nov 27, 2022
050df74
Set start and len simultaneously in longrangeiter_setstate.
serhiy-storchaka Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into range-iter
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Mar 28, 2022
commit abf2971d68e32813986973fd1c660201da886e47
4 changes: 2 additions & 2 deletions Objects/rangeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ rangeiter_reduce(rangeiterobject *r, PyObject *Py_UNUSED(ignored))
if (range == NULL)
goto err;
/* return the result */
return Py_BuildValue("N(N)O", _PyEval_GetBuiltinId(&PyId_iter),
return Py_BuildValue("N(N)O", _PyEval_GetBuiltin(&_Py_ID(iter)),
range, Py_None);
Comment on lines +798 to +799
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we care, but we might -- am I right that this writes pickles that can't be read by 3.11 or before?

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, absolutely no. I would never propose such change.

Internals will be different, but the unpickled iterator wil produce the same values.

err:
Py_XDECREF(start);
Expand Down Expand Up @@ -965,7 +965,7 @@ longrangeiter_reduce(longrangeiterobject *r, PyObject *Py_UNUSED(ignored))
}

/* return the result */
return Py_BuildValue("N(N)O", _PyEval_GetBuiltinId(&PyId_iter),
return Py_BuildValue("N(N)O", _PyEval_GetBuiltin(&_Py_ID(iter)),
range, Py_None);
}

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.