Skip to content

bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader#27981

Closed
DonnaDia wants to merge 3 commits into
python:mainfrom
DonnaDia:fix-issue-30274
Closed

bpo-30274: Rename 'name' to 'fullname' argument to ExtensionFileLoader#27981
DonnaDia wants to merge 3 commits into
python:mainfrom
DonnaDia:fix-issue-30274

Conversation

@DonnaDia
Copy link
Copy Markdown
Contributor

@DonnaDia DonnaDia commented Aug 26, 2021

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@DonnaDia

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@DonnaDia DonnaDia marked this pull request as ready for review August 29, 2021 18:28
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 29, 2021
@MaxwellDupre
Copy link
Copy Markdown
Contributor

I cant see why Azure Pipelines PR failed

Running Lib/test/test_importlib/extension/test_loader.py
doesn't produce anything meaningfull. How is this changed tested?

So ran full test and produced:

363 tests OK.

56 tests failed:

9 tests skipped:

56 re-run tests:

1 test run no tests.

Which doesn't look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants