Skip to content

bpo-40635: Fix getfqdn() docstring and docs #27971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 7 commits into from
Aug 26, 2021
+6 −4
Merged

bpo-40635: Fix getfqdn() docstring and docs #27971

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6df2299
Fix getfqdn() docstring and docs
akulakov Aug 26, 2021
dfe540a
update for accuracy
akulakov Aug 26, 2021
04eebb3
add the note on fallback logic
akulakov Aug 26, 2021
3730b48
use consistent quoting for name in docstring
akulakov Aug 26, 2021
a17e076
Update Lib/socket.py
akulakov Aug 26, 2021
0791bd9
updated rst paragraph per comments
akulakov Aug 26, 2021
5f74857
re-add newline
akulakov Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/socket.py 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
  • Loading branch information
@akulakov @ambv
akulakov and ambv authored Aug 26, 2021
commit a17e0761db6aa033b5f406fc304ee7371a418bc8
6 changes: 3 additions & 3 deletions Lib/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,9 +782,9 @@ def getfqdn(name=''):
An empty argument is interpreted as meaning the local host.

First the hostname returned by gethostbyaddr() is checked, then
possibly existing aliases. If that logic fails and `name` is empty or is
'0.0.0.0', hostname from gethostname() is returned. Otherwise, `name` is
returned unchanged.
possibly existing aliases. In case no FQDN is available and `name`
was given, it is returned unchanged. If `name` was empty or '0.0.0.0',
hostname from gethostname() is returned.
"""
name = name.strip()
if not name or name == '0.0.0.0':
Expand Down