Skip to content

bpo-44986: Fixed bug with date formats like %Y-%m-%d in help messages of argparse #27923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SengerM wants to merge 13 commits into from
+44 −1
Closed

bpo-44986: Fixed bug with date formats like %Y-%m-%d in help messages of argparse #27923

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
04f909d
Updated the usage of the '%(par)s' string formatting to modern f'{par…
SengerM Aug 23, 2021
36001c7
bpo-44986: Reverted change in test to stick to the old format and rep…
SengerM Aug 25, 2021
d77b2b6
Merge branch 'main' into main
SengerM Aug 22, 2023
255fa92
bpo-44986: Added unit tests for new feature that eliminates the need …
SengerM Aug 22, 2023
cbdc58e
bpo-44986: Added one extra test case with multiple percentage symbols
SengerM Aug 22, 2023
f291df2
bpo-44986: Added blurb entry
SengerM Aug 22, 2023
8ed8045
bpo-44986: Removed trailing white spaces
SengerM Aug 22, 2023
cd7aebb
Merge branch 'main' into main
SengerM Aug 22, 2023
1728042
Fixed GitHub issue number
SengerM Aug 22, 2023
8697b09
Merge branch 'main' into main
SengerM Aug 22, 2023
a3be094
Merge branch 'main' into main
furkanonder Sep 28, 2023
02e3b73
Merge branch 'main' into main
SengerM Aug 27, 2024
60c3e50
Merge branch 'main' into main
savannahostrowski Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-44986: Removed trailing white spaces
  • Loading branch information
@SengerM
SengerM committed Aug 22, 2023
commit 8ed80456b260b2648f61dd734425d8e58f4468ac
8 changes: 4 additions & 4 deletions Lib/test/test_argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3930,13 +3930,13 @@ class TestHelpWithPercentageSymbols(HelpTestCase):
"""Test a help message including % symbols"""
Copy link
Copy Markdown
Member

@savannahostrowski savannahostrowski Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test a help message including % symbols"""
"""Test help output that includes % symbols"""

parser_signature = Sig(prog='PROG', description='Just a test code.')
Copy link
Copy Markdown
Member

@savannahostrowski savannahostrowski Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parser_signature = Sig(prog='PROG', description='Just a test code.')
parser_signature = Sig(prog='PROG', description='Just a test program.')

argument_signatures = [
Sig('--somearg', metavar='somearg',
Sig('--somearg', metavar='somearg',
help='Now you dont need to escape this: %, and you will not get nonsensical errors!'),
Copy link
Copy Markdown
Member

@savannahostrowski savannahostrowski Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help='Now you dont need to escape this: %, and you will not get nonsensical errors!'),
help='No escape required for %'),

Sig('--date', metavar='when', help='A date in format %Y-%m-%d',
Sig('--date', metavar='when', help='A date in format %Y-%m-%d',
Copy link
Copy Markdown
Member

@savannahostrowski savannahostrowski Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sig('--date', metavar='when', help='A date in format %Y-%m-%d',
Sig('--date', metavar='when', help='A date in %Y-%m-%d format',

dest=f'date', type=str, required=True),
Sig('bar', nargs='?', type=int, default=42,
Sig('bar', nargs='?', type=int, default=42,
help='the bar to %(prog)s (default: %(default)s)'),
Copy link
Copy Markdown
Member

@savannahostrowski savannahostrowski Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help='the bar to %(prog)s (default: %(default)s)'),
help='The bar to %(prog)s (default: %(default)s)'),

Sig('--weirdarg', metavar='weird', dest=f'weird', type=str,
Sig('--weirdarg', metavar='weird', dest=f'weird', type=str,
required=True, help='A weird arg with 1 %, 2 %%% and 3 %%%%%'),
]

Expand Down