Skip to content

[3.9] bpo-42560: rewrite of Tkinter docs "life preserver" (GH-27842)#27911

Closed
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-08830a4-3.9
Closed

[3.9] bpo-42560: rewrite of Tkinter docs "life preserver" (GH-27842)#27911
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-08830a4-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 23, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 08830a4)

Co-authored-by: Mark Roseman mark@markroseman.com

https://bugs.python.org/issue42560

@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Aug 23, 2021
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels Aug 23, 2021
@roseman @miss-islington
bpo-42560: rewrite of Tkinter docs "life preserver" (pythonGH-27842)
9514c71 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 08830a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

@roseman and @ambv: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

@roseman and @ambv: Status check is done, and it's a failure ❌ .

@ambv ambv closed this Aug 23, 2021
@miss-islington miss-islington deleted the backport-08830a4-3.9 branch August 23, 2021 19:05
@terryjreedy

terryjreedy commented Aug 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Given that there was no merge conflict, why was this closed? If it it not going to be merged, the label on #27842 should be removed. I am asking in particular because bpo-45029 is about the old example, run in 3.9, that this replaces. So backporting the replacement seems like a good idea.

@E-Paine

E-Paine commented Sep 17, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@ambv Can we reopen this for merge? As Terry said, bpo-45029 is related to this, so IMO it would be nice to get this in the 3.9 docs.

@hpmason hpmason mannequin mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@miss-islington @terryjreedy @E-Paine @ambv @the-knights-who-say-ni @bedevere-bot @roseman