Skip to content

bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms #27614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 4 commits into from
Aug 6, 2021
+191 −61
Merged

bpo-44524: Fix an issue wherein _GenericAlias._name was not properly set for specialforms #27614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d3d1d3
Fix an issue wherein `_GenericAlias._name` was not properly set for s…
BvB93 Aug 4, 2021
bbdf4db
Add a `NEWS.d` entry
BvB93 Aug 5, 2021
ab3a89f
Apply suggestions from code review
BvB93 Aug 5, 2021
7ec545d
Reorder types in test_special_attrs, add more tests
ambv Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
  • Loading branch information
@BvB93 @Fidget-Spinner
BvB93 and Fidget-Spinner authored Aug 5, 2021
commit ab3a89f1d74408cbef146afa44199d1fb8a7678f
4 changes: 1 addition & 3 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,9 +1244,7 @@ def __subclasscheck__(self, cls):

def __reduce__(self):
func, (origin, args) = super().__reduce__()
if self._name == "Optional":
args = args[1] if args[0] is type(None) else args[0]
return func, (origin, args)
return func, (Union, args)


def _value_and_type_iter(parameters):
Expand Down
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Library/2021-08-05-18-20-17.bpo-44524.9T1tfe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Fixed an issue wherein the `__name__` and `__qualname__` attributes of
subscribed specialforms could be `None`.
Fixed an issue wherein the ``__name__`` and ``__qualname__`` attributes of
subscribed specialforms could be ``None``.