Skip to content

bpo-44807: Forbid to define __init__ method in Protocol classes #27543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uriyyo wants to merge 2 commits into from
Closed

bpo-44807: Forbid to define __init__ method in Protocol classes #27543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70c40f7
bpo-44807: Forbid to define __init__ method in Protocol classes
uriyyo Aug 2, 2021
751baac
Merge remote-tracking branch 'upstream/main' into fix-issue-44807
uriyyo Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'upstream/main' into fix-issue-44807 
# Conflicts:
#	Lib/test/test_typing.py
#	Lib/typing.py
  • Loading branch information
@uriyyo
uriyyo committed Sep 21, 2021
commit 751baac9f892be98ed1bf6dd4f1c117d17ba2c71
11 changes: 11 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,17 @@ class P(Protocol):
def __init__(self, x: int):
self.x = x

def test_super_call_init(self):
class P(Protocol):
x: int

class Foo(P):
def __init__(self):
super().__init__()

Foo() # Previously triggered RecursionError


class GenericTests(BaseTestCase):

def test_basics(self):
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,7 +1581,7 @@ def _proto_hook(other):
if '__init__' in cls.__dict__:
raise TypeError('Protocols can not have __init__ method')

cls.__init__ = _no_init
cls.__init__ = _no_init_or_replace_init


class _AnnotatedAlias(_GenericAlias, _root=True):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.