bpo-27275: Change popitem() and pop() methods of collections.OrderedDict#27530
Merged
Conversation
…tem(). The C implementation no longer calls ``__getitem__`` and ``__delitem__`` methods of the OrderedDict subclasses.
For consistency with dict both implementations (pure Python and C) of these methods in OrderedDict no longer call __getitem__ and __delitem__ methods of the OrderedDict subclasses. Previously only the Python implementation of popitem() did not call them.
Contributor
|
Based on Raymond's comment on the issue, we won't be backporting this as it's a behavioral change and there haven't been reports complaining of the old behavior. |
|
See astropy/astropy#13637 for a regression caused by this change. We may be able to work around this, but on the other hand we're unlikely to be the only project that counts on |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with dict both implementations (pure Python and C)
of these methods in OrderedDict no longer call
__getitem__and__delitem__methods of the OrderedDict subclasses.Previously only the Python implementation of popitem() did not
call them.
https://bugs.python.org/issue27275