Skip to content

bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes#2741

Merged
pitrou merged 3 commits into
python:masterfrom
gareth-rees:fix-issue-19896
Jul 21, 2017
Merged

bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes#2741
pitrou merged 3 commits into
python:masterfrom
gareth-rees:fix-issue-19896

Conversation

@gareth-rees
Copy link
Copy Markdown
Contributor

@gareth-rees gareth-rees commented Jul 17, 2017

Patch by Antony Lee.

https://bugs.python.org/issue19896

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jul 17, 2017

I think the AppVeyor failure is unrelated -- I got it on another PR.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jul 18, 2017

Thank you. This looks fine to me. This is still missing a NEWS entry as generated using the blurb tool. Do you want to do that?

gareth-rees and others added 2 commits July 18, 2017 13:25
Make it clear this is more of a fix rather than a new feature.
@pitrou pitrou changed the title bpo-19896: Add typcodes 'q' and 'Q' to multiprocessing.sharedctypes bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes Jul 18, 2017
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jul 18, 2017

I'm gonna close and reopen the issue to try and schedule a new AppVeyor build.

@pitrou pitrou closed this Jul 18, 2017
@pitrou pitrou reopened this Jul 18, 2017
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jul 21, 2017

Ok, AppVeyor build passed. i'm merging now. Thank you for submitting this PR!

@pitrou pitrou merged commit 3913bad into python:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants