Skip to content

bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode #27249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Jul 19, 2021
Merged

bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode #27249

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11ea638
Renamed assertLeadingPadding function to match logic
idan22moral Jul 19, 2021
00e63a9
Added a seperate error message for discontinuous padding
idan22moral Jul 19, 2021
45bfb77
Updated the tests for discontinuous padding
idan22moral Jul 19, 2021
9501e7e
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 19, 2021
beb8f04
seperate -> separate
gpshead Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated the tests for discontinuous padding
  • Loading branch information
@idan22moral
idan22moral committed Jul 19, 2021
commit 45bfb77f9e02d11fe828c731372eaab9b8754420
7 changes: 5 additions & 2 deletions Lib/test/test_binascii.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ def assertNonBase64Data(data, non_strict_mode_expected_result: bytes):
def assertLeadingPadding(data, non_strict_mode_expected_result: bytes):
_assertRegexTemplate(r'(?i)Leading padding', data, non_strict_mode_expected_result)

def assertDiscontinuousPadding(data, non_strict_mode_expected_result: bytes):
_assertRegexTemplate(r'(?i)Discontinuous padding', data, non_strict_mode_expected_result)

# Test excess data exceptions
assertExcessData(b'ab==a', b'i')
assertExcessData(b'ab===', b'i')
Expand All @@ -151,8 +154,8 @@ def assertLeadingPadding(data, non_strict_mode_expected_result: bytes):
assertLeadingPadding(b'=', b'')
assertLeadingPadding(b'==', b'')
assertLeadingPadding(b'===', b'')
assertLeadingPadding(b'ab=c=', b'i\xb7')
assertLeadingPadding(b'ab=ab==', b'i\xb6\x9b')
assertDiscontinuousPadding(b'ab=c=', b'i\xb7')
assertDiscontinuousPadding(b'ab=ab==', b'i\xb6\x9b')


def test_base64errors(self):
Expand Down