Skip to content

bpo-44524: Add missed __name__ and __qualname__ to typing module objects #27237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 6 commits into from
Jul 19, 2021
+72 −0
Merged

bpo-44524: Add missed __name__ and __qualname__ to typing module objects #27237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b91e82
Add missed __name__ and __qualname__ to typing module objects
uriyyo Jul 19, 2021
d683ee3
Include typing prefix for __qualname__ attr
uriyyo Jul 19, 2021
5440355
Revert "Include typing prefix for __qualname__ attr"
uriyyo Jul 19, 2021
6872f96
Add __name__ and __qualname__ to _SpecialForm
uriyyo Jul 19, 2021
583acb0
Update Misc/NEWS.d/next/Library/2021-07-19-14-04-42.bpo-44524.Nbf2JC.rst
uriyyo Jul 19, 2021
eb9f4ef
Use subTest for test_special_attrs
uriyyo Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add __name__ and __qualname__ to _SpecialForm
  • Loading branch information
@uriyyo
uriyyo committed Jul 19, 2021
commit 6872f961950236a3681479fdd8ce0fb583b3291a
12 changes: 12 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4501,6 +4501,7 @@ def test_no_isinstance(self):
class SpecialAttrsTests(BaseTestCase):
def test_special_attrs(self):
cls_to_check = (
# ABC classes
typing.AbstractSet,
typing.AsyncContextManager,
typing.AsyncGenerator,
Expand Down Expand Up @@ -4539,6 +4540,17 @@ def test_special_attrs(self):
typing.Tuple,
typing.Type,
typing.ValuesView,
# Special Forms
typing.Any,
typing.NoReturn,
typing.ClassVar,
typing.Final,
typing.Union,
typing.Optional,
typing.Literal,
typing.TypeAlias,
typing.Concatenate,
typing.TypeGuard,
)

for cls in cls_to_check:
Comment thread
uriyyo marked this conversation as resolved.
Expand Down
6 changes: 6 additions & 0 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,12 @@ def __init__(self, getitem):
self._name = getitem.__name__
self.__doc__ = getitem.__doc__

def __getattr__(self, item):
if item in {'__name__', '__qualname__'}:
return self._name

raise AttributeError(item)

def __mro_entries__(self, bases):
raise TypeError(f"Cannot subclass {self!r}")

Expand Down