Skip to content

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner#27210

Merged
ambv merged 1 commit into
python:mainfrom
ambv:remove-ivan
Jul 17, 2021
Merged

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner#27210
ambv merged 1 commit into
python:mainfrom
ambv:remove-ivan

Conversation

@ambv

@ambv ambv commented Jul 17, 2021

Copy link
Copy Markdown
Contributor

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though it feels weird seeing my handle there ;). We need to backport this to 3.10 and 3.9 too right? Otherwise backport PRs will ping Ivan.

@ambv

ambv commented Jul 17, 2021

Copy link
Copy Markdown
Contributor Author

Yes, this will indeed need backports.

@ambv

ambv commented Jul 17, 2021

Copy link
Copy Markdown
Contributor Author

Sorry, Ivan, address sanitizer refuses to let you go.

@ambv
ambv merged commit 311ee83 into python:main Jul 17, 2021
@bedevere-bot

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@ambv
ambv deleted the remove-ivan branch July 17, 2021 09:21
@bedevere-bot

Copy link
Copy Markdown

GH-27212 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 17, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot

Copy link
Copy Markdown

GH-27213 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@Fidget-Spinner

Copy link
Copy Markdown
Member

Wow we managed to break ASAN 😉.

Thanks again for handling this Łukasz!

@ambv

ambv commented Jul 17, 2021

Copy link
Copy Markdown
Contributor Author

Naturally, it's literally my job.

@Fidget-Spinner

Copy link
Copy Markdown
Member

Haha, congrats on the position :).

ambv added a commit that referenced this pull request Jul 17, 2021
) (#27213)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jul 17, 2021
) (#27212)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@isidentical

isidentical commented Jul 17, 2021

Copy link
Copy Markdown
Member

Ah, I think this might not work for triagers :/

The people you choose as code owners must have write permissions for the repository.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners

@ambv

ambv commented Jul 17, 2021

Copy link
Copy Markdown
Contributor Author

There's a few ways we can fix this 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants