Skip to content

bpo-44631: Make the repr() of the _Environ class more readable. #27128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 5 commits into from
Jul 20, 2021
Merged

bpo-44631: Make the repr() of the _Environ class more readable. #27128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9252dce
bpo-44631: Make the repr() of the _Environ class more readable.
Leonardofreua Jul 13, 2021
1ee1dc3
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 13, 2021
a60b0bb
Update Lib/os.py
Leonardofreua Jul 15, 2021
83501c4
bpo-44631: Remove the _mock_os_environ_repr method
Leonardofreua Jul 15, 2021
22a0bbc
bpo-44631: Update 2021-07-13-22-25-13.bpo-44631.qkGwe4.rst
Leonardofreua Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,9 +704,11 @@ def __len__(self):
return len(self._data)

def __repr__(self):
return 'environ({{{}}})'.format(', '.join(
('{!r}: {!r}'.format(self.decodekey(key), self.decodevalue(value))
for key, value in self._data.items())))
formatted_items = ", ".join(
f"{self.decodekey(key)!r}: {self.decodevalue(value)!r}"
for key, value in self._data.items()
)
return f"environ({{{formatted_items}}})"

def copy(self):
return dict(self)
Expand Down
8 changes: 5 additions & 3 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,9 +1029,11 @@ def test_items(self):
def test___repr__(self):
"""Check that the repr() of os.environ looks like environ({...})."""
env = os.environ
self.assertEqual(repr(env), 'environ({{{}}})'.format(', '.join(
'{!r}: {!r}'.format(key, value)
for key, value in env.items())))
formatted_items = ", ".join(
f"{key!r}: {value!r}"
for key, value in env.items()
)
self.assertEqual(repr(env), f"environ({{{formatted_items}}})")

def test_get_exec_path(self):
defpath_list = os.defpath.split(os.pathsep)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Documentation/2021-07-13-22-25-13.bpo-44631.qkGwe4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Refactored the ``repr()`` code of the ``_Environ`` (os module).