Skip to content

bpo-44490: Improve typing module compatibility with types.Union #27048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 10 commits into from
Jul 17, 2021
Merged

bpo-44490: Improve typing module compatibility with types.Union #27048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5b3570
bpo-44490: Fix various issues with types.Union
uriyyo Jul 6, 2021
0bc1800
Fix repr test
uriyyo Jul 6, 2021
d699211
Remove types.Union serialezation
uriyyo Jul 7, 2021
a00bfb4
Remove test_union_pickle
uriyyo Jul 7, 2021
4ad9b66
Add more tests to cover types.Union
uriyyo Jul 7, 2021
140a41a
Update Misc/NEWS.d/next/Core and Builtins/2021-07-06-22-22-15.bpo-444…
uriyyo Jul 8, 2021
6826d72
Update Lib/test/test_typing.py
uriyyo Jul 8, 2021
8b36d36
Update typing tests
uriyyo Jul 8, 2021
4081113
Update tests
uriyyo Jul 8, 2021
b92ba0d
Update tests
uriyyo Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests
  • Loading branch information
@uriyyo
uriyyo committed Jul 8, 2021
commit b92ba0d9c73df7c8fea504fee4a19acfe020e3b0
2 changes: 1 addition & 1 deletion Lib/test/ann_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,4 @@ def wrapper(*args, **kwargs):
return func(*args, **kwargs)
return wrapper

core_union: int | float
u: int | float
2 changes: 1 addition & 1 deletion Lib/test/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ class CC(metaclass=CMeta):
def test_var_annot_module_semantics(self):
self.assertEqual(test.__annotations__, {})
self.assertEqual(ann_module.__annotations__,
{1: 2, 'x': int, 'y': str, 'f': typing.Tuple[int, int]})
{1: 2, 'x': int, 'y': str, 'f': typing.Tuple[int, int], 'u': int | float})
self.assertEqual(ann_module.M.__annotations__,
{'123': 123, 'o': type})
self.assertEqual(ann_module2.__annotations__, {})
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2863,7 +2863,7 @@ def test_get_type_hints_from_various_objects(self):
gth(None)

def test_get_type_hints_modules(self):
ann_module_type_hints = {1: 2, 'f': Tuple[int, int], 'x': int, 'y': str, 'core_union': int | float}
ann_module_type_hints = {1: 2, 'f': Tuple[int, int], 'x': int, 'y': str, 'u': int | float}
self.assertEqual(gth(ann_module), ann_module_type_hints)
self.assertEqual(gth(ann_module2), {})
self.assertEqual(gth(ann_module3), {})
Expand Down