Skip to content

bpo-43950: Specialize tracebacks for subscripts/binary ops #27037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Jul 12, 2021
Merged

bpo-43950: Specialize tracebacks for subscripts/binary ops #27037

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a825ea
bpo-43950: Specialize tracebacks for subscripts/binary ops
isidentical Jul 5, 2021
d79d365
Port new specializations to traceback.py
ammaraskar Jul 10, 2021
26430d4
pass segmen_str around
isidentical Jul 10, 2021
081738d
Refactor and simplify the traceback code
pablogsal Jul 12, 2021
045c491
make amendments
isidentical Jul 12, 2021
012ae63
Use TESTFN instead of NamedTemporaryFile
ammaraskar Jul 12, 2021
825e3b0
Remove tempfile import
ammaraskar Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use TESTFN instead of NamedTemporaryFile
  • Loading branch information
@ammaraskar
ammaraskar committed Jul 12, 2021
commit 012ae63a7863b2c2cc07ce7204d46dab581d50e5
11 changes: 5 additions & 6 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,24 +464,23 @@ def f_with_subscript():
self.assertEqual(result_lines, expected_error.splitlines())

def test_traceback_specialization_with_syntax_error(self):
with tempfile.NamedTemporaryFile(mode="w", suffix=".py", delete=False) as file:
bytecode = compile("1 / 0 / 1 / 2\n", file.name, "exec")
bytecode = compile("1 / 0 / 1 / 2\n", TESTFN, "exec")

# make the file invalid
with open(TESTFN, "w") as file:
# make the file's contents invalid
file.write("1 $ 0 / 1 / 2\n")
file.flush()
self.addCleanup(unlink, TESTFN)

func = partial(exec, bytecode)
result_lines = self.get_exception(func)
os.unlink(file.name)

lineno_f = bytecode.co_firstlineno
expected_error = (
'Traceback (most recent call last):\n'
f' File "{__file__}", line {self.callable_line}, in get_exception\n'
' callable()\n'
' ^^^^^^^^^^\n'
f' File "{file.name}", line {lineno_f}, in <module>\n'
f' File "{TESTFN}", line {lineno_f}, in <module>\n'
" 1 $ 0 / 1 / 2\n"
' ^^^^^\n'
)
Expand Down