bpo-44558: Match countOf `is`/`==` treatment to c by Rupt · Pull Request #27007 · python/cpython

Rupt · 2021-07-03T17:44:32Z

The python implementation and docstrings currently treat these comparisons differently.

This change preserves the existing behaviour of the c implementation.

Add tests for cases where is and == differ.

https://bugs.python.org/issue44558

Python impl and docstring treated these comparisons differently. Update both docstrings to reflect the behavior. This preserves the existing behaviour of the c implementation.

the-knights-who-say-ni · 2021-07-03T17:44:35Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Rupt

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Rupt · 2021-07-03T17:47:31Z

Waiting "at least one business day" for CLA signing.

bedevere-bot · 2021-07-04T12:08:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Rupt · 2021-07-04T12:59:46Z

Replaced by #27012; closing.

Rupt · 2021-07-04T13:02:34Z

(oops - that is for indexOf - reopening)

…pTknl.rst Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

serhiy-storchaka

LGTM

Rupt · 2021-07-05T06:36:10Z

I have made the requested changes; please review again

(apologies if this is noise, but the box still says there is a change requested)

bedevere-bot · 2021-07-05T06:36:13Z

Thanks for making the requested changes!

@corona10, @serhiy-storchaka: please review the changes made to this pull request.

corona10

lgtm I am waiting for CLA

miss-islington · 2021-07-07T13:28:12Z

Thanks @Rupt for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington · 2021-07-07T13:28:28Z

Sorry, @Rupt and @corona10, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6bd3ecfc272b122b55a6adec50dd7a7c868f262f 3.9

bedevere-bot · 2021-07-07T13:28:30Z

GH-27053 is a backport of this pull request to the 3.10 branch.

(cherry picked from commit 6bd3ecf) Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>

bedevere-bot · 2021-07-07T13:50:59Z

GH-27054 is a backport of this pull request to the 3.9 branch.

…). (cherry picked from commit 6bd3ecf) Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>

Rupt · 2021-07-07T13:53:44Z

Thank you for all the help @corona10 :-)

…H-27055)

bpo-44558: Match countOf is/== treatment to c

cc0694c

Python impl and docstring treated these comparisons differently. Update both docstrings to reflect the behavior. This preserves the existing behaviour of the c implementation.

the-knights-who-say-ni added the CLA not signed label Jul 3, 2021

bedevere-bot added the awaiting review label Jul 3, 2021

Rupt and others added 3 commits July 3, 2021 19:16

Update with clinic

505bb1c

📜🤖 Added by blurb_it.

d9e673f

Remove blurb_it trailing whitespace

3debd3f

corona10 requested changes Jul 4, 2021

View reviewed changes

Comment thread Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0pTknl.rst Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Jul 4, 2021

corona10 requested review from serhiy-storchaka and vstinner July 4, 2021 12:08

Rupt closed this Jul 4, 2021

Rupt reopened this Jul 4, 2021

Update Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0…

44ccf3a

…pTknl.rst Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

corona10 reviewed Jul 4, 2021

View reviewed changes

Comment thread Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0pTknl.rst Outdated

Update Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0…

0015da8

…pTknl.rst Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

serhiy-storchaka approved these changes Jul 5, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Jul 5, 2021

serhiy-storchaka mentioned this pull request Jul 5, 2021

bpo-44558: Make the implementation consistency of operator.indexOf #27012

Merged

bedevere-bot added awaiting change review and removed awaiting merge labels Jul 5, 2021

bedevere-bot requested a review from corona10 July 5, 2021 06:36

bedevere-bot requested a review from serhiy-storchaka July 5, 2021 06:36

corona10 added needs backport to 3.9 needs backport to 3.10 only security fixes labels Jul 5, 2021

corona10 approved these changes Jul 5, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jul 5, 2021

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jul 7, 2021

corona10 merged commit 6bd3ecf into python:main Jul 7, 2021

bedevere-bot removed the awaiting merge label Jul 7, 2021

miss-islington assigned corona10 Jul 7, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2021

bpo-44558: Match countOf is/== treatment to c (pythonGH-27007)

2102ea0

(cherry picked from commit 6bd3ecf) Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>

miss-islington added a commit that referenced this pull request Jul 7, 2021

bpo-44558: Match countOf is/== treatment to c (GH-27007)

9f431dd

(cherry picked from commit 6bd3ecf) Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>

Rupt mentioned this pull request Jul 7, 2021

[3.9] bpo-44558: Match countOf is/== treatment to c (GH-27007) #27053 #27054

Closed

bedevere-bot removed the needs backport to 3.9 label Jul 7, 2021

corona10 pushed a commit to corona10/cpython that referenced this pull request Jul 7, 2021

[3.9] bpo-44558: Match countOf is/== treatment to c (pythonGH-27007…

3cf620f

…). (cherry picked from commit 6bd3ecf) Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>

corona10 added a commit that referenced this pull request Jul 7, 2021

[3.9] bpo-44558: Match countOf is/== treatment to c (GH-27007). (G…

9761abf

…H-27055)

pablogsal mentioned this pull request Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

Uh oh!

Conversation

Rupt commented Jul 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jul 3, 2021

CLA Missing

Uh oh!

Rupt commented Jul 3, 2021

Uh oh!

Uh oh!

bedevere-bot commented Jul 4, 2021

Uh oh!

Rupt commented Jul 4, 2021

Uh oh!

Rupt commented Jul 4, 2021

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Rupt commented Jul 5, 2021

Uh oh!

bedevere-bot commented Jul 5, 2021

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jul 7, 2021

Uh oh!

miss-islington commented Jul 7, 2021

Uh oh!

bedevere-bot commented Jul 7, 2021

Uh oh!

bedevere-bot commented Jul 7, 2021

Uh oh!

Rupt commented Jul 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rupt commented Jul 3, 2021 •

edited

Loading