Skip to content

bpo-43908: Types with Py_TPFLAGS_IMMUTABLETYPE can now inherit the vectorcall protocol #27001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 15 commits into from
Jul 8, 2021
Merged

bpo-43908: Types with Py_TPFLAGS_IMMUTABLETYPE can now inherit the vectorcall protocol #27001

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6f2a997
bpo-43908: Let Py_TPFLAGS_IMMUTABLETYPE decide if Py_TPFLAGS_HAVE_VEC…
Jul 2, 2021
c1db2ce
Adjust test_call comments
Jul 2, 2021
dd42fdf
Py_TPFLAGS_METHOD_DESCRIPTOR is inherited if Py_TPFLAGS_IMMUTABLETYPE…
Jul 2, 2021
f3aedd3
Update docs
Jul 2, 2021
0e421ab
Add a note in Porting to 3.11
Jul 2, 2021
a99cd5c
Add NEWS
Jul 2, 2021
e9ee79c
Simplify What's New/NEWS wording
Jul 2, 2021
593a19f
Fix whitespace
Jul 2, 2021
6adc9e5
Move What's New entry from 3.11 to 3.10
Jul 6, 2021
c9cdfa6
Revert "Move What's New entry from 3.11 to 3.10"
Jul 6, 2021
634d1d9
Minor adjustment of What's New wording
Jul 6, 2021
1b035eb
Address review: reword NEWS entry
Jul 6, 2021
b6ed6bd
Also adjust What's New entry
Jul 6, 2021
fd33dcc
Address review: change wording in NEWS entry (specify heap types)
Jul 7, 2021
49362db
Also adjust What's New entry
Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Py_TPFLAGS_METHOD_DESCRIPTOR is inherited if Py_TPFLAGS_IMMUTABLETYPE… 
… is set
  • Loading branch information
Erlend E. Aasland committed Jul 2, 2021
commit dd42fdf14bd801663fb15400e52e1b84c835e758
4 changes: 2 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5915,8 +5915,8 @@ inherit_slots(PyTypeObject *type, PyTypeObject *base)
* but only for extension types */
if (base->tp_descr_get &&
type->tp_descr_get == base->tp_descr_get &&
!(type->tp_flags & Py_TPFLAGS_HEAPTYPE) &&
(base->tp_flags & Py_TPFLAGS_METHOD_DESCRIPTOR))
_PyType_HasFeature(type, Py_TPFLAGS_IMMUTABLETYPE) &&
_PyType_HasFeature(base, Py_TPFLAGS_METHOD_DESCRIPTOR))
{
type->tp_flags |= Py_TPFLAGS_METHOD_DESCRIPTOR;
}
Expand Down