Skip to content

Remove duplicate versionadded#26995

Closed
hongshaoyang wants to merge 1 commit into
python:mainfrom
hongshaoyang:remove-duplicate-versionadded
Closed

Remove duplicate versionadded#26995
hongshaoyang wants to merge 1 commit into
python:mainfrom
hongshaoyang:remove-duplicate-versionadded

Conversation

@hongshaoyang

Copy link
Copy Markdown

No description provided.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@hongshaoyang

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gvanrossum

Copy link
Copy Markdown
Member

Those are not duplicate -- several features really was added twice to two different bugfix releases.

@gvanrossum gvanrossum closed this Jul 2, 2021
@hongshaoyang hongshaoyang deleted the remove-duplicate-versionadded branch July 3, 2021 03:30
@hongshaoyang

Copy link
Copy Markdown
Author

For features with multiple versionadded's, would it help to specify what was added in that version? To me the docs look slightly confusing currently.

Screenshot 2021-07-03 at 12 34 18 PM

@gvanrossum

Copy link
Copy Markdown
Member

When it says "New in version X" under the description of a class, function etc., it means that that thing was introduced in that version and wasn't present in the previous versions. So for these examples, these were not present in 3.5.3 or 3.6.0.

Maybe it helps you understand to know that "minor" versions (3.5, 3.6 etc.) are descendents/ancestors of each other, but "bugfix" versions (3.5.4, 3.6.1 etc.) are descendants of the previous bugfix version? E.g. 3.6.1 is a descendant of 3.6.0, i.e. 3.6.

@hongshaoyang

Copy link
Copy Markdown
Author

Thank you for the detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants