Skip to content

bpo-44490: Add __parameters__ and __getitem__ to types.Union #26980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 14 commits into from
Jul 6, 2021
Merged

bpo-44490: Add __parameters__ and __getitem__ to types.Union #26980

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bb7713b
bpo-44490: Add __parameters__ to types.Union
uriyyo Jul 1, 2021
4d1a60b
Add Py_LIMITED_API to genericaliasobject
uriyyo Jul 1, 2021
71b306e
Update Lib/test/test_types.py
uriyyo Jul 1, 2021
09d441c
Update Misc/NEWS.d/next/Core and Builtins/2021-07-01-11-59-34.bpo-444…
uriyyo Jul 1, 2021
8033e53
Update Objects/unionobject.c
uriyyo Jul 1, 2021
59f54af
Update Include/genericaliasobject.h
uriyyo Jul 1, 2021
2072f7e
Update genericaliasobject.c
uriyyo Jul 1, 2021
cea63d4
Update unionobject.c
uriyyo Jul 1, 2021
27980f1
Update Lib/test/test_types.py
uriyyo Jul 1, 2021
afbb038
Update test_types.py
uriyyo Jul 1, 2021
8cfa980
Add parameters to union_traverse
uriyyo Jul 3, 2021
1a1ac84
Update Objects/genericaliasobject.c
uriyyo Jul 5, 2021
7799a15
Add more tests to cover types.Union
uriyyo Jul 5, 2021
0b61365
Merge remote-tracking branch 'upstream/main' into fix-issue-44490
uriyyo Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/genericaliasobject.c 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
  • Loading branch information
@uriyyo @gvanrossum
uriyyo and gvanrossum authored Jul 5, 2021
commit 1a1ac841b4f3ad0b5b1ca09afd6d753e327cf5ad
2 changes: 1 addition & 1 deletion Objects/genericaliasobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ static PyObject *
ga_getitem(PyObject *self, PyObject *item)
{
gaobject *alias = (gaobject *)self;
// do a lookup for __parameters__ so it gets populated (if not already)
// Populate __parameters__ if needed.
if (alias->parameters == NULL) {
alias->parameters = _Py_make_parameters(alias->args);
if (alias->parameters == NULL) {
Expand Down