Skip to content

bpo-43950: Print columns in tracebacks (PEP 657) #26958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 5 commits into from
Jul 4, 2021
Merged

bpo-43950: Print columns in tracebacks (PEP 657) #26958

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17fd03b
bpo-43950: Print columns in tracebacks (PEP 657)
isidentical Jul 4, 2021
9a31711
Address feedback from @isidentical
ammaraskar Jul 4, 2021
83f0260
Remove TODO about highlighting to end
ammaraskar Jul 4, 2021
1a5a4cf
Remove stale TODO
ammaraskar Jul 4, 2021
58e2f7f
Move byte_offset_to_character_offset to the parser API
pablogsal Jul 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove TODO about highlighting to end
  • Loading branch information
@ammaraskar
ammaraskar committed Jul 4, 2021
commit 83f0260ac4b6fe4e005f961f4a529996a11c5202
4 changes: 0 additions & 4 deletions Python/traceback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,6 @@ tb_displayline(PyTracebackObject* tb, PyObject *f, PyObject *filename, int linen
if (start_col_byte_offset < 0 || end_col_byte_offset < 0) {
goto done;
}
if (end_col_byte_offset == -1) {
// TODO: highlight from start_offset to the end of line
goto done;
}
// Convert the utf-8 byte offset to the actual character offset so we
// print the right number of carets.
Py_ssize_t start_offset = _byte_offset_to_character_offset(source_line, start_col_byte_offset);
Expand Down