Skip to content

bpo-44404: tkinter after support callable classes#26812

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
E-Paine:tkinter-callable-class
Jun 23, 2021
Merged

bpo-44404: tkinter after support callable classes#26812
serhiy-storchaka merged 5 commits into
python:mainfrom
E-Paine:tkinter-callable-class

Conversation

@E-Paine

@E-Paine E-Paine commented Jun 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@E-Paine

E-Paine commented Jun 20, 2021

Copy link
Copy Markdown
Contributor Author

Quick note: as far as I can tell, all other usages of __name__ are safe (i.e. not going to raise an AttributeError).

@E-Paine E-Paine changed the title bpo-44404: tkinter support callable classes bpo-44404: tkinter after support callable classes Jun 20, 2021
serhiy-storchaka
serhiy-storchaka reviewed Jun 20, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

serhiy-storchaka
serhiy-storchaka reviewed Jun 20, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-06-20-19-01-11.bpo-44404.McfrYB.rst Outdated
E-Paine and others added 2 commits June 20, 2021 20:50
@E-Paine @serhiy-storchaka
news rephrasing
c23ee2e 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@E-Paine
Add tests
66eb621
@E-Paine

E-Paine commented Jun 20, 2021

Copy link
Copy Markdown
Contributor Author

Pipelines failure is related to issue 44384

@E-Paine E-Paine requested a review from serhiy-storchaka June 21, 2021 19:27
serhiy-storchaka
serhiy-storchaka reviewed Jun 22, 2021
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_misc.py
@E-Paine

E-Paine commented Jun 22, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka please could you set the Windows x64 test to rerun (it failed due to a connection issue - presumably temporary)

serhiy-storchaka
serhiy-storchaka approved these changes Jun 22, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit e9c8f78 into python:main Jun 23, 2021
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.10 only security fixes label Jun 23, 2021
@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Sorry @E-Paine and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9c8f784fa13ea3a51df3b72a498a3896ec9e768 3.10

@bedevere-bot

This comment has been minimized.

Sign in to view
@E-Paine

E-Paine commented Jun 24, 2021

Copy link
Copy Markdown
Contributor Author

Great, thanks Serhiy!

@E-Paine E-Paine deleted the tkinter-callable-class branch June 24, 2021 07:29
@terryjreedy terryjreedy added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jun 26, 2021
@miss-islington

miss-islington commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

Sorry @E-Paine and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9c8f784fa13ea3a51df3b72a498a3896ec9e768 3.10

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jun 26, 2021
@miss-islington

miss-islington commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Jun 26, 2021

Copy link
Copy Markdown

GH-26921 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 26, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2021
@E-Paine @miss-islington
bpo-44404: tkinter after support callable classes (pythonGH-26812)
5817550 
(cherry picked from commit e9c8f78)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@terryjreedy

terryjreedy commented Jun 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Buildbot failure in test_compile (hiddden) is
test_stack_overflow (test.test_compile.TestSpecifics) ... *** Signal 9

This is first time I have seen 'trouble checking out...' twice on one issue. Trying again.
... and it worked this time.

miss-islington added a commit that referenced this pull request Jun 27, 2021
@miss-islington @E-Paine
bpo-44404: tkinter after support callable classes (GH-26812)
e1f3bd2 
(cherry picked from commit e9c8f78)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@E-Paine @miss-islington @bedevere-bot @terryjreedy @serhiy-storchaka @the-knights-who-say-ni