Skip to content

Mention build.bat counterpart in GH workflows error message#26770

Merged
terryjreedy merged 1 commit into
python:mainfrom
Fidget-Spinner:patch-1
Jul 27, 2021
Merged

Mention build.bat counterpart in GH workflows error message#26770
terryjreedy merged 1 commit into
python:mainfrom
Fidget-Spinner:patch-1

Conversation

@Fidget-Spinner
Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner commented Jun 17, 2021

No description provided.

@Fidget-Spinner
Copy link
Copy Markdown
Member Author

Fidget-Spinner commented Jun 17, 2021

@terryjreedy would you like me to create an issue for this as well (and add news) or do you feel that isn't necessary?

@terryjreedy terryjreedy requested a review from zooba June 17, 2021 16:00
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Jun 17, 2021

@zooba Just to make sure, is "build.bat --regen" the proper equivalent of "make regen-all"?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 18, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 18, 2021
@ammaraskar
Copy link
Copy Markdown
Member

ammaraskar commented Jul 27, 2021

@zooba Just to make sure, is "build.bat --regen" the proper equivalent of "make regen-all"?

Not Steve but just wanted to say that it is indeed the correct command, see the PR it was added in for reference: #12654

Adds an additional project to the PCbuild.sln that runs the equivalent commands that are in the regen-all stage in the Makefile.

@ammaraskar ammaraskar removed the stale Stale PR or inactive for long period of time. label Jul 27, 2021
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Jul 27, 2021

Thank you. That confirms -regen is part of 3.9, so can backport this.

@terryjreedy terryjreedy merged commit d61b69f into python:main Jul 27, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 27, 2021

Thanks @Fidget-Spinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 27, 2021

GH-27382 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 27, 2021

GH-27383 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2021
@Fidget-Spinner @miss-islington
Add windows build.bat counterpart for 'make regen-all' in error messa…
e90bc15 
…ge (pythonGH-26770)

(cherry picked from commit d61b69f)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2021
@Fidget-Spinner @miss-islington
Add windows build.bat counterpart for 'make regen-all' in error messa…
404634c 
…ge (pythonGH-26770)

(cherry picked from commit d61b69f)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jul 27, 2021
@miss-islington @Fidget-Spinner
Add windows build.bat counterpart for 'make regen-all' in error messa…
b631d8d 
…ge (GH-26770)

(cherry picked from commit d61b69f)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request Jul 27, 2021
@miss-islington @Fidget-Spinner
Add windows build.bat counterpart for 'make regen-all' in error messa…
a13edfb 
…ge (GH-26770)

(cherry picked from commit d61b69f)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Jul 27, 2021

Both backports merged.

@Fidget-Spinner Fidget-Spinner deleted the patch-1 branch July 30, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Fidget-Spinner @terryjreedy @ammaraskar @miss-islington @bedevere-bot @the-knights-who-say-ni