Skip to content

bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly#26764

Merged
serhiy-storchaka merged 2 commits into
mainfrom
unknown repository
Jun 22, 2021
Merged

bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol correctly#26764
serhiy-storchaka merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 17, 2021 •
edited by ghost
Loading

The underlying C codes handle buffer protocol objects correctly, so only fix the wrong length in Python code is fine.

https://bugs.python.org/issue44439

@wjssz
BZ2File.write()/LZMAFile.write() handle length correctly
5884185 
No longer use len() to get the length of the input data. For some buffer protocol objects, the length obtained by using len() is wrong.
serhiy-storchaka
serhiy-storchaka reviewed Jun 22, 2021
View reviewed changes
Comment thread Lib/test/test_gzip.py Outdated
Comment thread Lib/bz2.py Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit bc6c12c into python:main Jun 22, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2021

Thanks @animalize for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2021

Sorry, @animalize and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bc6c12c72a9536acc96e7b9355fd69d1083a43c1 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 22, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 22, 2021

GH-26845 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2021
@miss-islington
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol …
559d927 
…correctly (pythonGH-26764)

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
@ghost ghost deleted the input_len branch June 22, 2021 07:12
@ghost ghost mentioned this pull request Jun 22, 2021
Merged
@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 22, 2021

3.9 branch has a code conflict, I created PR #26846 for 3.9 branch.

serhiy-storchaka pushed a commit that referenced this pull request Jun 22, 2021
@miss-islington
bpo-44439: BZ2File.write() / LZMAFile.write() handle buffer protocol …
01858fb 
…correctly (GH-26764) (GH-26845)

No longer use len() to get the length of the input data. For some buffer protocol objects,
the length obtained by using len() is wrong.
(cherry picked from commit bc6c12c)

Co-authored-by: Ma Lin <animalize@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@animalize animalize mannequin mentioned this pull request Apr 12, 2022
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni @wjssz