Skip to content

bpo-24132: Direct sub-classing of pathlib.Path #26438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kfollstad wants to merge 11 commits into from
Closed

bpo-24132: Direct sub-classing of pathlib.Path #26438

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f011491
bpo-24132: Add stub SimplePath/FilePath classes to pathlib
kfollstad Apr 30, 2021
ff1d455
bpo-24132: Replace hardcoded references where possible in pathlib
kfollstad Apr 30, 2021
488994f
bpo-24132: Refactor PurePath methods into base class in pathlib
kfollstad May 3, 2021
6a69e0d
bpo-24132: Completed SimplePath in pathlib
kfollstad May 3, 2021
09317e2
bpo-24132: Partial implmentation of FilePath in pathlib
kfollstad May 3, 2021
d966acf
bpo-24132: Fix inconsistent organization of is_mount in pathlib
kfollstad May 27, 2021
ed5f237
bpo-24132: Replace additional hardcoded references in pathlib
kfollstad May 3, 2021
ecc341b
bpo-24132: Completed FilePath in pathlib
kfollstad May 5, 2021
2700e46
bpo-24123: Add SimplePosixPath and SimpleWindowsPath to pathlib
kfollstad May 25, 2021
d15d8da
bpo-24132: Fix validity of inter-path comparison in pathlib
kfollstad May 26, 2021
6028b6d
bpo-24132: Document FilePath and SimplePath family in pathlib
kfollstad May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-24132: Fix validity of inter-path comparison in pathlib 
Fix _BasePurePath comparison operators so that all of the new
path classes in pathlib are comparable with one another and return
results that are consistent with the existing behavoir, i.e.
Path('/') == PurePath('/').
  • Loading branch information
@kfollstad
kfollstad committed May 28, 2021
commit d15d8da8ebb3d23934f2ca476d063cee0480f863
10 changes: 5 additions & 5 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ def _cparts(self):
return self._cached_cparts

def __eq__(self, other):
if not isinstance(other, self.__class__):
if not isinstance(other, _PurePathBase):
return NotImplemented
return (
self._cparts == other._cparts
Expand All @@ -676,31 +676,31 @@ def __hash__(self):

def __lt__(self, other):
if (
not isinstance(other, self.__class__)
not isinstance(other, _PurePathBase)
or self._flavour is not other._flavour
):
return NotImplemented
return self._cparts < other._cparts

def __le__(self, other):
if (
not isinstance(other, self.__class__)
not isinstance(other, _PurePathBase)
or self._flavour is not other._flavour
):
return NotImplemented
return self._cparts <= other._cparts

def __gt__(self, other):
if (
not isinstance(other, self.__class__)
not isinstance(other, _PurePathBase)
or self._flavour is not other._flavour
):
return NotImplemented
return self._cparts > other._cparts

def __ge__(self, other):
if (
not isinstance(other, self.__class__)
not isinstance(other, _PurePathBase)
or self._flavour is not other._flavour
):
return NotImplemented
Expand Down