bpo-44110: Improve string's __getitem__ error message#26042
Merged
Conversation
serhiy-storchaka
approved these changes
May 13, 2021
JelleZijlstra
approved these changes
May 18, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
A similar enhancement to list IndexError msg was recently rejected for performance reasons. I wonder if the same objection may apply here (most likely less so because the same pattern of catching index errors in a loop would be used rarely with strings). I will try to check performance later today, though I was having some odd issues with pyperf (but this may be a good chance to debug them :) ). related issue: |
Contributor
|
After looking at the pattern that was an issue with the list IndexError, it should not apply to strings, so please ignore my comment! |
Member
|
Yes, because it is a TypeError, not IndexError. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44110