bpo-29615: SimpleXMLRPCDispatcher no longer chains KeyError (or any other exception) to exception(s) raised in the dispatched methods.#260

Merged

serhiy-storchaka merged 31 commits into

python:masterfrom

petr-motejlek:issue29615

Mar 1, 2017

Commits on Feb 23, 2017

issue29615: _dispatch function is no longer called in an except block
Petr MOTEJLEK
committed

Commits on Feb 27, 2017

issue29615 (review): use `functools.wraps` and remove the keyword-only argument call
Petr MOTEJLEK
committed
issue29615 (review): do not chain the exceptions, refrain from attempts to invoke `None`
Petr MOTEJLEK
committed

Commits on Feb 28, 2017

issue29615 (review): remove unused `functools`
Petr MOTEJLEK
committed
issue29615 (review): attempts to mimic the original behavior while getting rid of the exception chaining
Petr MOTEJLEK
committed
issue29615 (review): verifies KeyError`s (no exceptions actually) are no longer chained to exceptions raised within `_dispatch` function
Petr MOTEJLEK
committed
issue29615 (review): entry for these changes in Misc/NEWS
Petr MOTEJLEK
committed
Merge remote-tracking branch 'MASTER/master' into issue29615
Petr MOTEJLEK
committed
Merge remote-tracking branch 'MASTER/master' into issue29615
Petr MOTEJLEK
committed
issue29615 (review): tests that ensure no exception chaining takes place when calling dispatched funcs
Petr MOTEJLEK
committed
issue29615 (review): created a separate SimpleXMLRPCDispatcherTestCase and renamed tests in it to have shorter names
Petr MOTEJLEK
committed
issue29615 (review): defines test case level DispatchExc and uses it, uses self.assertRaises to ensure it was raised
Petr MOTEJLEK
committed
issue29615 (review): proper assert test
Petr MOTEJLEK
committed
issue29615 (review): removed the assert delegation from DispatchExc and moved it higher
Petr MOTEJLEK
committed
issue29615 (review): removed keyword arguments when calling `_dispatch`
Petr MOTEJLEK
committed
issue29615 (review): no longer staticmethod
Petr MOTEJLEK
committed
issue29615 (review): removed unnecessary else block
Petr MOTEJLEK
committed
issue29615 (review): fewer `raise`s
Petr MOTEJLEK
committed
issue29615 (review): reformulated and moved to the appropriate place
Petr MOTEJLEK
committed
issue29615 (review): removed
Petr MOTEJLEK
committed

Commits on Mar 1, 2017

issue29615 (review): uses `Exception.args`; shorter lines
Petr MOTEJLEK
committed
issue29615 (review): consisten use if `if` condition
Petr MOTEJLEK
committed
issue29615 (review): uses assertTupleEqual to compare tuples; tests the behavior when no function can be located by the dispatcher
Petr MOTEJLEK
committed
issue29615 (review): tests what happens when explicitly registered function is None
Petr MOTEJLEK
committed
issue29615 (review): checks what happens when a registered instance's attribute does not exist
Petr MOTEJLEK
committed
issue29615 (review): typography
Petr MOTEJLEK
committed
issue29615 (review): uses `assertEqual` instead of `assertTupleEqual`
Petr MOTEJLEK
committed
issue29615 (review): shorter diff
Petr MOTEJLEK
committed
Merge remote-tracking branch 'MASTER/master' into issue29615
Petr MOTEJLEK
committed
issue29615 (review): moving the NEWS item to the proper place
Petr MOTEJLEK
committed
issue29615 (review): typo
Petr MOTEJLEK
committed