Skip to content

[3.9] bpo-36384: Leading zeros in IPv4 addresses are no longer tolerated (GH-25099)#25815

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-60ce8f0-3.9
May 2, 2021
Merged

[3.9] bpo-36384: Leading zeros in IPv4 addresses are no longer tolerated (GH-25099)#25815
ambv merged 1 commit into
python:3.9from
miss-islington:backport-60ce8f0-3.9

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented May 2, 2021 •
edited by bedevere-bot
Loading

Reverts commit e653d4d and makes
parsing even more strict. Like socket.inet_pton() any leading zero
is now treated as invalid input.

Signed-off-by: Christian Heimes christian@python.org

Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 60ce8f0)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue36384

@tiran @miss-islington
bpo-36384: Leading zeros in IPv4 addresses are no longer tolerated (p…
03c7a34 
…ythonGH-25099)

Reverts commit e653d4d and makes
parsing even more strict. Like socket.inet_pton() any leading zero
is now treated as invalid input.

Signed-off-by: Christian Heimes <christian@python.org>

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 60ce8f0)

Co-authored-by: Christian Heimes <christian@python.org>
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 2, 2021
Merged
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added the type-security A security issue label May 2, 2021
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented May 2, 2021

@tiran and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit 5374fbc into python:3.9 May 2, 2021
@miss-islington miss-islington deleted the backport-60ce8f0-3.9 branch May 2, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @ambv @the-knights-who-say-ni @bedevere-bot @tiran