Skip to content

bpo-41277: Mapping correct values in the os.setxattr() documentation#25742

Merged
ericvsmith merged 1 commit into
python:masterfrom
shreyneil:patch-1
May 1, 2021
Merged

bpo-41277: Mapping correct values in the os.setxattr() documentation#25742
ericvsmith merged 1 commit into
python:masterfrom
shreyneil:patch-1

Conversation

@shreyneil

@shreyneil shreyneil commented Apr 30, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown

https://bugs.python.org/issue41277

Automerge-Triggered-By: GH:ericvsmith

@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 30, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shreyneil

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Apr 30, 2021
@shreyneil

shreyneil commented Apr 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Happy and excited to open my first PR towards the goal of contributing to this project.
@rhettinger, have signed the CLA and mailed to contributors mailing list, it would be great if you can add the skip news label and review the PR.

@shreyneil

shreyneil commented May 1, 2021

Copy link
Copy Markdown
Author

@ericvsmith can you review this one ?

ericvsmith
ericvsmith approved these changes May 1, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. It's the tested behavior in ExtendedAttributeTests.

@ericvsmith ericvsmith merged commit 7792324 into python:master May 1, 2021
@miss-islington

miss-islington commented May 1, 2021

Copy link
Copy Markdown
Contributor

Thanks @shreyneil for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2021
@miss-islington
Fix exceptions mentioned in os.setxattr() docs (pythonGH-25742)
0336ccf 
(cherry picked from commit 7792324)

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>
@bedevere-bot

bedevere-bot commented May 1, 2021

Copy link
Copy Markdown

GH-25794 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2021
@miss-islington
Fix exceptions mentioned in os.setxattr() docs (pythonGH-25742)
103951c 
(cherry picked from commit 7792324)

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>
@bedevere-bot

bedevere-bot commented May 1, 2021

Copy link
Copy Markdown

GH-25795 is a backport of this pull request to the 3.8 branch.

@shreyneil shreyneil deleted the patch-1 branch May 1, 2021 20:55
ericvsmith pushed a commit that referenced this pull request May 1, 2021
@miss-islington
Fix exceptions mentioned in os.setxattr() docs (GH-25742) (GH-25794)
10a62bb 
(cherry picked from commit 7792324)

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>
ericvsmith pushed a commit that referenced this pull request May 1, 2021
@miss-islington
Fix exceptions mentioned in os.setxattr() docs (GH-25742) (GH-25795)
ce081fb 
(cherry picked from commit 7792324)

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shreyneil @the-knights-who-say-ni @miss-islington @bedevere-bot @ericvsmith