Skip to content

bpo-43012: remove pathlib._Accessor #25701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 15 commits into from
Feb 2, 2022
Merged

bpo-43012: remove pathlib._Accessor #25701

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7d33921
Call `accessor.getcwd()` from only one method.
barneygale Apr 28, 2021
740953b
Call `accessor.stat()` from only one method.
barneygale Apr 28, 2021
57f40f7
Call `accessor.scandir()` from only one method.
barneygale Apr 28, 2021
f3855f8
Call `accessor.link()` from only one method.
barneygale Apr 28, 2021
734940f
Delete `pathlib._Accessor`.
barneygale Apr 28, 2021
3dfefdf
Fix broken `test_glob_permissions` test.
barneygale Apr 28, 2021
613a171
Rename `Path.scandir()` to `Path._scandir()`
barneygale May 13, 2021
d07f465
Simplify handling of missing `os.readlink()`, `symlink()` and `link()`.
barneygale May 14, 2021
013ddc6
Add comment explaining why we access the filesystem via `Path` object…
barneygale Jan 5, 2022
c9ffcf9
Move comment to `Path._scandir()` definition.
barneygale Jan 5, 2022
3783a6a
Add news entry
barneygale Jan 5, 2022
8aabc5d
Undo changes to selector classes.
barneygale Jan 9, 2022
d3c363b
Merge branch 'main' into bpo-43012-remove-pathlib-accessor
barneygale Jan 20, 2022
37d5127
Merge branch 'main' into bpo-43012-remove-pathlib-accessor
barneygale Jan 29, 2022
cfaf15f
Fix up broken merge from main.
barneygale Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix broken test_glob_permissions test.
  • Loading branch information
@barneygale
barneygale committed Jan 1, 2022
commit 3dfefdfee037205809c69e208cc51bf023cc4a92
24 changes: 11 additions & 13 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import contextlib
import collections.abc
import io
import os
Expand Down Expand Up @@ -1716,21 +1717,18 @@ def test_glob_permissions(self):
# Patching is needed to avoid relying on the filesystem
# to return the order of the files as the error will not
# happen if the symlink is the last item.

with mock.patch("os.scandir") as scandir:
scandir.return_value = sorted(os.scandir(base))
real_scandir = os.scandir
def my_scandir(path):
with real_scandir(path) as scandir_it:
entries = list(scandir_it)
entries.sort(key=lambda entry: entry.name)
return contextlib.nullcontext(entries)

with mock.patch("os.scandir", my_scandir):
self.assertEqual(len(set(base.glob("*"))), 3)

subdir.mkdir()

with mock.patch("os.scandir") as scandir:
scandir.return_value = sorted(os.scandir(base))
subdir.mkdir()
self.assertEqual(len(set(base.glob("*"))), 4)

subdir.chmod(000)

with mock.patch("os.scandir") as scandir:
scandir.return_value = sorted(os.scandir(base))
subdir.chmod(000)
self.assertEqual(len(set(base.glob("*"))), 4)

def _check_resolve(self, p, expected, strict=True):
Expand Down