Skip to content

bpo-43908: Make array.array type immutable #25696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Apr 29, 2021
+10 −1
Merged

bpo-43908: Make array.array type immutable #25696

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a86129d
bpo-43908: Apply Py_TPFLAGS_IMMUTABLETYPE to array.array
Apr 26, 2021
0b0a496
Add NEWS
Apr 26, 2021
29c6746
Add test
Apr 28, 2021
8348018
Improve NEWS entry wording
Apr 28, 2021
551f93e
Address review: explain the purpose of the test
Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ def test_bad_constructor(self):
self.assertRaises(TypeError, array.array, 'xx')
self.assertRaises(ValueError, array.array, 'x')

@support.cpython_only
def test_immutable(self):
Comment thread
erlend-aasland marked this conversation as resolved.
with self.assertRaises(TypeError):
array.array.foo = 1

def test_empty(self):
# Exercise code for handling zero-length arrays
a = array.array('B')
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2021-04-26-20-59-17.bpo-43908.-COW4-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Apply :const:`Py_TPFLAGS_IMMUTABLETYPE` flag to :class:`array.array`. Patch by
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
Erlend E. Aasland.
3 changes: 2 additions & 1 deletion Modules/arraymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2847,7 +2847,8 @@ static PyType_Slot array_slots[] = {
static PyType_Spec array_spec = {
.name = "array.array",
.basicsize = sizeof(arrayobject),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,
.flags = (Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE |
Py_TPFLAGS_IMMUTABLETYPE),
.slots = array_slots,
};

Expand Down