Skip to content

[2.7] bpo-30843: regrtest fixes sys.path, restore test.bisect#2567

Merged
vstinner merged 1 commit into
python:2.7from
vstinner:regrtest_path27
Jul 5, 2017
Merged

[2.7] bpo-30843: regrtest fixes sys.path, restore test.bisect#2567
vstinner merged 1 commit into
python:2.7from
vstinner:regrtest_path27

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Jul 4, 2017

  • Rename again Lib/test/bisectcmd.py to Lib/test/bisect.py
  • regrtest now removes '' and Lib/test/ from sys.path
  • Use absolute import in test_bisect

@vstinner
bpo-30843: regrtest fixes sys.path, restore test.bisect
802c1ae 
* Rename again Lib/test/bisectcmd.py to Lib/test/bisect.py
* regrtest now removes '' and Lib/test/ from sys.path
* Use absolute import in test_bisect
@vstinner vstinner requested review from brettcannon and ncoghlan July 4, 2017 14:45
@vstinner vstinner merged commit 3050987 into python:2.7 Jul 5, 2017
@vstinner vstinner deleted the regrtest_path27 branch July 5, 2017 07:16
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Jul 5, 2017

Thank you @brettcannon and @ncoghlan, I wasn't confident in that change since my previous attempt introduced a strange bug in multiprocessing when the test is run again. But I like @ncoghlan analysis of the regrtest bug introducing Lib/test/ in sys.path. Let's see how buildbots like test.bisect ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @brettcannon @ncoghlan @the-knights-who-say-ni