Skip to content

distutils._msvccompiler: _get_vc_env() - correction of the erroneous - #25447

Closed
carlkl wants to merge 1 commit into
python:mainfrom
carlkl:msvccompiler
Closed

distutils._msvccompiler: _get_vc_env() - correction of the erroneous #25447
carlkl wants to merge 1 commit into
python:mainfrom
carlkl:msvccompiler

Conversation

@carlkl

@carlkl carlkl commented Apr 16, 2021

Copy link
Copy Markdown

…command line for subprocess

Correction for _get_vc_env() in distutils._msvccompiler

The command line used with subprocess to estimate the environment for Visual Studio is not functional in the way it is used. cmd has to be started with the /k flag instead and stopped with the exit command.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@carlkl

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@merwok

merwok commented May 11, 2021

Copy link
Copy Markdown
Member

distutils has moved from the standard library, please report to https://github.com/pypa/distutils/issues/

@merwok merwok closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants