bpo-28911: Clarify the behaviour of assert_called_once_with.#251
Conversation
|
|
||
| Assert that the mock was called exactly once and with the specified | ||
| arguments. | ||
| Assert that the mock was called exactly once and that that call was |
There was a problem hiding this comment.
"that that"? "that the call"? "that call"?
Sorry, english is not my first language, so I don't know if it's correct or not!
There was a problem hiding this comment.
I understand that it does look a bit weird at first, but it is acceptable English: http://english.stackexchange.com/questions/3418/how-do-you-handle-that-that-the-double-that-problem
It could be rephrased, but that would make it longer/more complex.
There was a problem hiding this comment.
Yeah, it's a little awkward but totally fine.
Lukasa
left a comment
There was a problem hiding this comment.
These seem like reasonable clarifications to me, and the grammar is totally fine. 👍
|
|
||
| Assert that the mock was called exactly once and with the specified | ||
| arguments. | ||
| Assert that the mock was called exactly once and that that call was |
There was a problem hiding this comment.
Yeah, it's a little awkward but totally fine.
|
This PR should be backported to 3.6: @153957 can you write cherry-pick the fix and propose a PR for that? Use "git cherry-pick -x" |
Upstream fix for bpo-39386 broke Stackless test case test_pickle.TestAsyncGenPickling.
Upstream fix for bpo-39386 broke Stackless test case test_pickle.TestAsyncGenPickling. (cherry picked from commit c3f61b0)
No description provided.