bpo-43597: add ability to specify sslcontext in RobotFileParser.read()#24986
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Hi @berkerpeksag is there anything that I can do to move this PR forward? |
berkerpeksag
left a comment
There was a problem hiding this comment.
This PR needs a documentation update (see Doc/library/urllib.robotparser.rst) and test cases (see Lib/test/test_robotparser.py)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
|
@berkerpeksag can you please let me know if there are any other changes required? |
|
Hi @berkerpeksag are you ok with the changes? is this good to merge? |
|
Ping @berkerpeksag |
|
Hi @berkerpeksag please help with merging this. |
|
@berkerpeksag ping |
|
Hi @berkerpeksag please review and approve this PR when you can. I've made the necessary changes. |
|
Hi? Is anyone available to look at this? |
|
@orsenthil (as an urllib expert) @jackjansen, @dstufft, @alex (as ssl experts) |
|
two and half years later - is there an update ? can someone please take a look? |
|
Hi? Is anyone available to look at this? |
Add ability to specify a sslcontext in RobotFileParser.read()
Default is None, existing behavior is preserved
https://bugs.python.org/issue43597
https://bugs.python.org/issue43597