Skip to content

bpo-43588: use static variable module under building Python with --with-experimental-isolated-subinterpreters cause crash. #24963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dexterhahaha wants to merge 1 commit into from
Closed

bpo-43588: use static variable module under building Python with --with-experimental-isolated-subinterpreters cause crash. #24963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-43588: use static variable module under building Python with --wi… 
…th-experimental-isolated-subinterpreters cause crash.
  • Loading branch information
xiejunyi committed Mar 22, 2021
commit 82463c54a2b227ea47e9af13a5a2b0a89b35332c
10 changes: 5 additions & 5 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1868,14 +1868,14 @@ compiler_body(struct compiler *c, asdl_stmt_seq *stmts)
static PyCodeObject *
compiler_mod(struct compiler *c, mod_ty mod)
{
_Py_static_string(_module, "<module>");
PyCodeObject *co;
int addNone = 1;
static PyObject *module;
if (!module) {
module = PyUnicode_InternFromString("<module>");
if (!module)
return NULL;
PyObject *module = _PyUnicode_FromId(&_module); // borrowed ref
if (module == NULL) {
return NULL;
}

/* Use 0 for firstlineno initially, will fixup in assemble(). */
if (!compiler_enter_scope(c, module, COMPILER_SCOPE_MODULE, mod, 1))
return NULL;
Expand Down