Skip to content

bpo-43317: Use io.DEFAULT_BUFFER_SIZE instead of arbitrary number in gzip module #24645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
Feb 26, 2021
Merged

bpo-43317: Use io.DEFAULT_BUFFER_SIZE instead of arbitrary number in gzip module #24645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb09b0
Use io.DEFAULT_BUFFER_SIZE instead of arbitrary number in gzip module
rhpvorderman Feb 25, 2021
ebeacbf
Add news entry
rhpvorderman Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use io.DEFAULT_BUFFER_SIZE instead of arbitrary number in gzip module 
This improves the performance slightly, while also using a constant that is shared across the python code base.
  • Loading branch information
@rhpvorderman
rhpvorderman committed Feb 25, 2021
commit 5cb09b0c8a655a2a893593579a02ddb0919879e6
2 changes: 1 addition & 1 deletion Lib/gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ def main():
f = builtins.open(arg, "rb")
g = open(arg + ".gz", "wb")
while True:
chunk = f.read(1024)
chunk = f.read(io.DEFAULT_BUFFER_SIZE)
if not chunk:
break
g.write(chunk)
Expand Down