Skip to content

bpo-43269: Clean up sqlite3 file scope #24578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 8 commits into from
Feb 21, 2021
Merged

bpo-43269: Clean up sqlite3 file scope #24578

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81edfda
Fix scope and normalise argument spec
Jan 11, 2021
23b108f
Add Py_UNUSED
Feb 19, 2021
bd5c345
Address review: Remove 'extern' keyword
Feb 20, 2021
5a159fb
Address review: revert OoS style changes
Feb 20, 2021
1c63733
Revert _pysqlite_step_callback
Feb 20, 2021
8487b88
Really revert _authorizer_callback
Feb 20, 2021
e97517f
Revert pysqlite_connection_set_isolation_level
Feb 20, 2021
03ca40a
Restore pysqlite_cursor_setup_types
Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Really revert _authorizer_callback
  • Loading branch information
Erlend E. Aasland committed Feb 20, 2021
commit 8487b88f07c4f2201ec5a5dd38a1de3952b38df9
2 changes: 1 addition & 1 deletion Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ pysqlite_connection_create_aggregate_impl(pysqlite_Connection *self,
Py_RETURN_NONE;
}

static int _authorizer_callback(void* user_arg, int action, const char* arg1, const char* arg2, const char* dbname, const char* access_attempt_source)
static int _authorizer_callback(void* user_arg, int action, const char* arg1, const char* arg2 , const char* dbname, const char* access_attempt_source)
{
PyObject *ret;
int rc;
Expand Down