Skip to content

gh-74895: getaddrinfo no longer raises OverflowError #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 9 commits into from
Feb 14, 2023
Merged

gh-74895: getaddrinfo no longer raises OverflowError #2435

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe317a4
bpo-30710: getaddrinfo does not raise OverflowError
smejkar Jun 27, 2017
06de3c3
Merge branch 'main' into bpo-30710
arhadthedev Feb 13, 2023
874cb15
Add a news entry
arhadthedev Feb 13, 2023
2175a89
Clean up after an incorrect merge
arhadthedev Feb 13, 2023
399c274
Merge branch 'main' into bpo-30710
gpshead Feb 13, 2023
2ec8318
use out of range service/port values across all platforms
gpshead Feb 13, 2023
7328057
Rework the test to allow gaierror or no-error.
gpshead Feb 14, 2023
ba80744
editing typo fix
gpshead Feb 14, 2023
5bfdda4
lol typo
gpshead Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use out of range service/port values across all platforms 
Some systems treat it as unsigned internally so ULONG_MAX+1 is needed, not LONG_MAX+1.
  • Loading branch information
@gpshead
gpshead authored Feb 13, 2023
commit 2ec83186afd94c587d912dab836d03297fb8c6ec
4 changes: 3 additions & 1 deletion Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,9 +1605,11 @@ def test_getaddrinfo_overflow(self):
# Issue #30710: test that getaddrinfo does not raise OverflowError
import _testcapi
with self.assertRaises(socket.gaierror):
socket.getaddrinfo(None, _testcapi.LONG_MAX + 1)
socket.getaddrinfo(None, _testcapi.ULONG_MAX + 1)
with self.assertRaises(socket.gaierror):
socket.getaddrinfo(None, _testcapi.LONG_MIN - 1)
with self.assertRaises(socket.gaierror):
socket.getaddrinfo(None, -1)

def test_getnameinfo(self):
# only IP addresses are allowed
Expand Down